Fix(OrderMerger): Do not carry line item adjustments to new order #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjustments are connected to the spree_orders table via two ways: - via their adjustable's (line item's) order ID - via their own order ID If we move a line item with adjustments to new order, the adjustment's order ID will not be changed to the new order. Instead of changing the foreign key of an existing line item here, let's build a new line item with the old line item's attributes.
mamhoff
force-pushed
the
fix-merged-order-adjustments
branch
from
bfdbaef to
afc2ded
Compare
tvdeyen
approved these changes
Mar 3, 2022
kennyadsl
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjustments are connected to the spree_orders table via two ways:
If we move a line item with adjustments to new order, the adjustment's
order ID will not be changed to the new order.
Instead of changing the foreign key of an existing line item here, let's
build a new line item with the old line item's attributes.
Checklist: