Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more room for long values in Order Summary #4352

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Make more room for long values in Order Summary #4352

merged 2 commits into from
Apr 25, 2022

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 22, 2022

Description

Using flex box to be more flexible (pun intended) with long keys in the order summary.

Before

Lieferungen - R987654321 - Bestellungen 2022-04-22 10-42-01

After

Lieferungen - R987654321 - Bestellungen 2022-04-22 10-42-21

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have attached screenshots to this PR for visual changes

tvdeyen added 2 commits April 22, 2022 10:30
@tvdeyen
Move dl style rules into lists partial
731a510 
Definition list (dl) is clearly not a typography topic
@tvdeyen
Make more room for long values in DL
efd969b 
Using flex box to be more flexible (pun intended) with long keys in the order summary.
@tvdeyen tvdeyen added UI changelog:solidus_backend Changes to the solidus_backend gem labels Apr 22, 2022
mamhoff
mamhoff approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

This was referenced Apr 22, 2022
Merged
Merged
Merged
kennyadsl
kennyadsl approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

jarednorman
jarednorman approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@tvdeyen tvdeyen merged commit 349e4c7 into solidusio:master Apr 25, 2022
@tvdeyen tvdeyen deleted the fix-dl-style branch April 25, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tvdeyen @kennyadsl @jarednorman @mamhoff