Sanitize i18n keys using i18n-tasks gem issue: #3978 #4437
Conversation
i18n-tasks gem helps in managing translations. For now we don't use the tasks in our test pipeline. Added config and test for `api/` and `core/`. Signed-off-by: Shubham Pandey <[email protected]>
waiting-for-dev
force-pushed
the
feature/normalise-i18n-keys
branch
from
83b5dab to
56b2d73
Compare
|
|
||
| require 'i18n/tasks' | ||
|
|
||
| RSpec.describe I18n do |
There was a problem hiding this comment.
Just a nit, but do you think it would make sense to turn this into a set of shared examples?
Bonus: would it make sense to add this to solidus_dev_support?
There was a problem hiding this comment.
Just a nit, but do you think it would make sense to turn this into a set of shared examples?
As it is code automatically generated by the i18n-tasks gem, I think it's better to leave things as they're now. For instance, they could add a new task to update that code, which could not work in our case if we changed it.
Bonus: would it make sense to add this to solidus_dev_support?
Yeah, that's an excellent point for the extensions.
There was a problem hiding this comment.
Hey @aldesantis, are you ok with that? 🙂
There was a problem hiding this comment.
@aldesantis ping, so we can merge this one!
There was a problem hiding this comment.
Merging, we can always extract it as a follow-up work 🙂
i18n-tasks gem helps in managing translations. For now we don't use the
tasks in our test pipeline. Added config and test for
api/andcore/.Taking over #4187
Closes #3978