Remove PayPal as an option during the installation process #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
changed the title
PayPal has stopped supporting its Ruby SDK [1]. From its README: > This SDK is deprecated. You can continue to use it, but no new features or support requests will be accepted. For alternatives, please visit the current SDK homepage on the PayPal Developer Portal From the PR [2] that introduced the deprecation message: > There is no team at PayPal that supports this repo right now (and, in > fact, the documentation for SDK has been removed from the PayPal docs > site). > > My team is in the process of creating replacement SDKs for integrating > with PayPal, but until those are available our official recommendation > is to do one of the following: > > A) Use the API directly > B) Continue using the current SDK, but know that no further updates > will be made outside of necessary security updates On top of that, the SDK is locked to paypalhttp_ruby lesser than 2 [3], but Ruby 3 is only supported since that version [4]. That combines to make it impossible to use Ruby > 3 + Solidus + PayPal extension. If PayPal restarts giving support to Ruby, we'll add it again as an option in the installer for solidus_frontend [5]. [1] - https://github.com/paypal/Checkout-Ruby-SDK [2] - https://github.com/paypal/Checkout-Ruby-SDK/pull/34#issuecomment-1190523120 [3] - https://github.com/paypal/Checkout-Ruby-SDK/blob/7170ecd5656d9e9f96a4d0ce0ee31b59b3a8268b/paypal-checkout-sdk.gemspec#L22 [4] - paypal/paypalhttp_ruby#12 (comment) [5] - https://github.com/solidusio/solidus_frontend/blob/master/lib/generators/solidus_frontend/install/install_generator.rb
waiting-for-dev
force-pushed
the
waiting-for-dev/remove_paypal_from_the_installer
branch
from
81bb12c to
1bf1963
Compare
aldesantis
approved these changes
Aug 8, 2022
jarednorman
approved these changes
Aug 8, 2022
spaghetticode
approved these changes
Aug 8, 2022
waiting-for-dev
deleted the
waiting-for-dev/remove_paypal_from_the_installer
branch
4 tasks
waiting-for-dev
added a commit
to solidusio/edgeguides
that referenced
this pull request
Aug 9, 2022
It's no longer an option in the script See solidusio/solidus#4494
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PayPal has stopped supporting its Ruby SDK. From its README:
From the PR that introduced the deprecation message:
On top of that, the SDK is locked to paypalhttp_ruby lesser than 2,
but Ruby 3 is only supported since that version. That combines to
make it impossible to use Ruby > 3 + Solidus + PayPal extension.
If PayPal restarts giving support to Ruby, we'll add it again as an
option in the installer for solidus_frontend.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have updated the readme to account for my changes.