Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SQLite job to the CI #4525

Merged
merged 6 commits into from
Aug 25, 2022
Merged

Add a SQLite job to the CI #4525

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba41130
Simulate a validation error on LegacyUser and restore spec
elia Aug 23, 2022
5cdc40b
Restore SQLite specs that were previously skipped
elia Aug 23, 2022
5ceb789
Avoid the "already initialized constant" warnings with net/ libraries
elia Aug 23, 2022
2888203
Suppress AR migration output inside specs
elia Aug 23, 2022
c6a1967
Improve error messages for a misconfigured test DB
elia Aug 23, 2022
e81727d
Add sqlite executor to CI
waiting-for-dev Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ executors:
- image: *image
- image: cimg/mysql:5.7

sqlite:
working_directory: *workdir
environment:
<<: *environment
DB: sqlite
docker:
- image: *image

Comment on lines +40 to +47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should add this to the https://github.com/solidusio/circleci-orbs-extensions repo as well so extensions also can opt-in to running specs against SQLite on CI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in solidusio/circleci-orbs-extensions#48, will be released in v0.4.0

commands:
setup:
steps:
Expand Down Expand Up @@ -139,6 +147,14 @@ jobs:
- setup
- test

sqlite:
executor: sqlite
parallelism: *parallelism
steps:
- setup
- libvips
- test

postgres_rails60:
executor: postgres
parallelism: *parallelism
Expand Down Expand Up @@ -168,6 +184,7 @@ workflows:
only: /master|v\d\.\d+/
- postgres
- mysql
- sqlite
- postgres_rails61
- postgres_rails60
- postgres_rails52
Expand Down