Cleanup Gemfile groups #4537
Merged
Cleanup Gemfile groups #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the 'i18n-tasks' gem to top-level as it's being used by core and api specs.
We're not testing against it, can be revisited if we'll add it back to the CI.
`fast_sqlite` already depends on `sqlite3`.
Also suggested upstream in lsegal/yard#1457.
elia
force-pushed
the
elia/gemfile-frontend-group
branch
from
7422672 to
417937f
Compare
github-actions
bot
added
the
changelog:solidus_core
kennyadsl
approved these changes
Sep 6, 2022
elia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
:frontendgroup was still present in the Gemfile, also we can skip a few gems in the CI.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):I have added automated tests to cover my changes.I have attached screenshots to demo visual changes.I have opened a PR to update the guides.I have updated the readme to account for my changes.