Don't remove non-accessible roles when assigning new accessible roles #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the current ability logged in assigned new roles to which they have access to a user, other non-accessible roles were removed. We're now ensuring that non-accessible roles are not touched. It also fixes the roles being saved twice: once on the generic `user#update` and a second on `#set_roles`. Now, that only happens in the latter situation. Fixes solidusio#4528
github-actions
bot
added
changelog:solidus_backend
elia
reviewed
Sep 8, 2022
kennyadsl
approved these changes
Sep 8, 2022
jarednorman
approved these changes
Sep 8, 2022
waiting-for-dev
deleted the
waiting-for-dev/dont_remove_unauthorized_roles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the current ability logged in assigned new roles to which they have access to a user, other non-accessible roles were removed. We're now ensuring that non-accessible roles are not touched.
It also fixes the roles being saved twice: once on the generic
user#updateand a second on#set_roles. Now, that only happens in the latter situation.Fixes #4528
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the readme to account for my changes.