Require mail >= 2.8.0.rc1 for Ruby 3.1 support #4734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
changed the title
github-actions
bot
added
the
changelog:solidus_core
|
mikel/mail@d9d8dcc as reference |
|
I can live with that, but in case you missed it, there's a typo in the commit message. 🙂 |
Ruby 3.1 removed net-smtp, net-imap and net-pop from standardlib and extracted them into independent gems. The mail gem >= 2.8.0.rc1 added them to their dependencies. Since we require the mail gem in core.rb:17 we need to add the mail gem as dependency and need to make sure it is the Ruby 3.1 compatible version as we support Ruby 3.1
tvdeyen
force-pushed
the
ruby-3.1-fixes
branch
from
c69fdbf to
ed4bd8a
Compare
Ha! Thanks :) Fixed |
tvdeyen
changed the title
|
LOL! Rails PR anyone?
|
|
We can probably remove the |
tvdeyen
added a commit
to tvdeyen/solidus
that referenced
this pull request
Nov 23, 2022
This was added a long time ago and is actually not necessary anymore. If a shop depends on mail then through actionmailer. Refs solidusio#4734
|
Closed in favor of #4740 |
|
Thanks @waiting-for-dev for pointing me to the obvious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ruby 3.1 removed net-smtp, net-imap and net-pop from standardlib and extracted them into independent gems.
The mail gem >= 2.8 added them to their dependencies. Since we require the mail gem in core.rb:17 we need to add the mail gem as dependency and need to make sure it is the Ruby 3.1 compatible version as we support Ruby 3.1
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: