Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.2] Remove trailing zeroes in tax amount #4770

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 7, 2022

Backport

This will backport the following commits from master to v3.2:

Questions ?

Please refer to the Backport tool documentation

NumberToPercentageConverter defaults to a precision of 3, leading to
displays of VAT amount like '21.000%' on the cart's label, which doesn't
look good. Using `precision: nil` will keep the default precision of the
number.

(cherry picked from commit 5483bc1)
@github-actions github-actions bot force-pushed the backport/v3.2/pr-4758 branch from 4a6f86a to 7a88734 Compare December 7, 2022 05:42
@waiting-for-dev waiting-for-dev changed the title [v3.2] Merge pull request #4758 from Naokimi/remove-trailing-zeroes-in-tax-amount [v3.2] Remove trailing zeroes in tax amount Dec 7, 2022
@tvdeyen
Copy link
Member

tvdeyen commented Dec 7, 2022

Rerunning CI

@waiting-for-dev waiting-for-dev merged commit aacf90d into v3.2 Dec 7, 2022
@waiting-for-dev waiting-for-dev deleted the backport/v3.2/pr-4758 branch December 7, 2022 09:44
@waiting-for-dev waiting-for-dev added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem labels Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants