Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3.2] Hide soft deleted prices from admin product view #4836

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[v3.2] Hide soft deleted prices from admin product view #4836

merged 1 commit into from
Jan 5, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 4, 2023

Backport

This will backport the following commits from master to v3.2:

Questions ?

Please refer to the Backport tool documentation

@tvdeyen
Hide soft deleted prices from admin product view
cad6cc5 
The `product.prices` relation has been changed in 3f4578a
to make eager loading possible, but this now shows soft deleted
prices in the admin product prices tab.

Hiding them again to restore previous behavior.

(cherry picked from commit 9da5ebf)
@github-actions github-actions bot requested a review from a team as a code owner January 4, 2023 12:24
@github-actions github-actions bot mentioned this pull request Jan 4, 2023
Merged
7 tasks
@kennyadsl kennyadsl changed the title [v3.2] Merge pull request #4832 from tvdeyen/do-not-show-deleted-prices [v3.2] Hide soft deleted prices from admin product view Jan 5, 2023
@kennyadsl kennyadsl added type:bug Error, flaw or fault changelog:solidus_backend Changes to the solidus_backend gem labels Jan 5, 2023
@kennyadsl kennyadsl merged commit 15924fe into v3.2 Jan 5, 2023
@kennyadsl kennyadsl deleted the backport/v3.2/pr-4832 branch January 5, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adammathys adammathys adammathys approved these changes

@jarednorman jarednorman jarednorman approved these changes

Assignees

@tvdeyen tvdeyen

Labels
changelog:solidus_backend Changes to the solidus_backend gem type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jarednorman @adammathys @tvdeyen @kennyadsl