Fix sticky admin nav on long menu #4884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Solidus, the admin nav menu becomes sticky after scrolling the page. If the menu contains a few entries, everything works fine. But if the menu includes some entries and the height exceed the window height, since the menu is sticky, the latest entries will be hidden. This commit applies the sticky only if the menu height does not exceed the window height.
github-actions
bot
added
the
changelog:solidus_backend
|
This is the result after the fix: Screen.Recording.2023-01-26.at.18.24.28.mov |
|
There are other CSS issues (the menu border and the white background between the primary and user menus). Solving these could be a bit tricky, but if this PR is accepted, I can work on them in a separate PR. |
Codecov Report
@@ Coverage Diff @@
## master #4884 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 577 577
Lines 14678 14678
=======================================
Hits 12660 12660
Misses 2018 2018 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MassimilianoLattanzio
deleted the
ml/fix-sticky-admin-nav-on-long-menu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Solidus, the admin nav menu becomes sticky after scrolling the page. If the menu contains a few entries, everything works fine. But if the menu includes some entries and the height exceed the window height, since the menu is sticky, the latest entries will be hidden.
Example with short menu:
Screen.Recording.2023-01-26.at.18.12.45.mov
Example with long menu:
Screen.Recording.2023-01-26.at.18.14.59.mov
This PR applies the sticky only if the menu height does not exceed the window height.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):