[v3.2] Fix CI only testing with the legacy event system adapter #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
From solidusio#4666 all CI jobs have been running with the legacy event system. We were defaulting the `legacy` parameter to `0`, which we copied over to the `USE_LEGACY_EVENTS` environment variable. However, the test suite was checking for the mere existence of the environment variable to select the legacy adapter and not for an actual `1` value. We are now: - Renaming the `legacy` parameter to `legacy_events` to be clearer. - Making the parameter a boolean one, defaulting to false. - Checking that `USE_LEGACY_EVENTS` is the string `"true"` before selecting the legacy adapter. - Using the legacy adapter for the job on Ruby 2.7 & Rails 6.0. - Adding `-legacy_events` to the job name when selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backports #4880 to v3.2
From #4666 all CI jobs have
been running with the legacy event system. We were defaulting the
legacyparameter to0, which we copied over to theUSE_LEGACY_EVENTSenvironment variable. However, the test suite waschecking for the mere existence of the environment variable to select
the legacy adapter and not for an actual
1value.We are now:
legacyparameter tolegacy_eventsto be clearer.USE_LEGACY_EVENTSis the string"true"beforeselecting the legacy adapter.
-legacy_eventsto the job name when selected.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):[ ] I have added automated tests to cover my changes.[ ] I have attached screenshots to demo visual changes.[ ] I have opened a PR to update the guides.[ ] I have updated the README to account for my changes.