[v3.3] Fix publishing events responding to #to_hash on Ruby 2.7 #4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When a method accepts both splatted positional & keyword parameters and
a single argument responding to `#to_hash` is given, the argument is
coerced to hash and assigned to the keyword arguments.
E.g.:
class Hashable
def to_hash
{ im: :a_hash }
end
end
def method_with_splat_on_the_positional_argument(*args, **kwargs) # method_with_splat_on_the_positional_argument(Hashable.new)
puts args.inspect # => []
puts kwargs.inspect # => {:im=>:a_hash}
end
However,
def method_without_splat_on_the_positional_argument(args, **kwargs) # method_without_splat_on_the_positional_argument(Hashable.new)
puts args.inspect # => #<Hashable:0x000055cfe8b072b0>
puts kwargs.inspect # => {}
end
We fix the problem on the Spree::Bus override by being explicit about
the expected parameters.
References solidusio/solidus_stripe#157 (comment)
(cherry picked from commit d69f8d7)
3 tasks
waiting-for-dev
changed the title
Codecov Report
@@ Coverage Diff @@
## v3.3 #4895 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 577 577
Lines 14678 14678
=======================================
Hits 12660 12660
Misses 2018 2018
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertov3.3:Questions ?
Please refer to the Backport tool documentation