Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of sample images #4924

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

F-Hamid
Copy link

@F-Hamid F-Hamid commented Feb 8, 2023

Update the images extension form PNG to JPG in : solidus/sample/db/samples/assets.rb

@F-Hamid F-Hamid requested a review from a team as a code owner February 8, 2023 16:04
@github-actions github-actions bot added the changelog:solidus_sample Changes to the solidus_sample gem label Feb 8, 2023
@waiting-for-dev
Copy link
Contributor

Should we close #4921 in favor of this one? 🤔

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #4924 (1d3c48d) into master (d7ef0f2) will increase coverage by 15.61%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4924       +/-   ##
===========================================
+ Coverage   71.08%   86.69%   +15.61%     
===========================================
  Files         578      578               
  Lines       15611    14673      -938     
===========================================
+ Hits        11097    12721     +1624     
+ Misses       4514     1952     -2562     
Impacted Files Coverage Δ
backend/lib/spree/backend/action_callbacks.rb 100.00% <0.00%> (+40.00%) ⬆️
backend/lib/spree/backend/callbacks.rb 93.33% <0.00%> (+46.66%) ⬆️
backend/lib/spree/backend_configuration.rb 100.00% <0.00%> (+48.57%) ⬆️
...controllers/spree/admin/option_types_controller.rb 60.00% <0.00%> (+60.00%) ⬆️
...d/app/controllers/spree/admin/taxons_controller.rb 66.66% <0.00%> (+66.66%) ⬆️
.../app/helpers/spree/admin/stock_movements_helper.rb 70.58% <0.00%> (+70.58%) ⬆️
...s/spree/admin/promotion_code_batches_controller.rb 75.00% <0.00%> (+75.00%) ⬆️
...ollers/spree/admin/promotion_actions_controller.rb 81.25% <0.00%> (+81.25%) ⬆️
...d/app/controllers/spree/admin/stores_controller.rb 83.33% <0.00%> (+83.33%) ⬆️
...trollers/spree/admin/promotion_rules_controller.rb 83.33% <0.00%> (+83.33%) ⬆️
... and 53 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kennyadsl kennyadsl changed the title Images extension Reduce size of sample images Feb 9, 2023
@kennyadsl kennyadsl added the type:enhancement Proposed or newly added feature label Feb 9, 2023
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@waiting-for-dev waiting-for-dev merged commit f06fb16 into solidusio:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_sample Changes to the solidus_sample gem type:enhancement Proposed or newly added feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants