Introduce allowed_ransackable_scopes #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
RyanofWoods
force-pushed
the
ryanofwoods/move-ransackable-scopes
branch
from
ae1765d to
708794c
Compare
ransackable_scopes is currently declared on two models, although other ransackable methods are declared through RansackableAttributes. By this move, the codebase becomes more consistent.
By using allowed_ransackable_scopes which was introduced in the last commit, stores will be able to easily concatenate to the arrays already declared on Product and Promotion in Solidus.
RyanofWoods
force-pushed
the
ryanofwoods/move-ransackable-scopes
branch
from
708794c to
a68e768
Compare
kennyadsl
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Thanks @RyanofWoods, this makes sense. I left a detective question 🕵️♂️, to better understand any possible backward compatibility issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce
allowed_ransackable_scopesto:ransackable_scopesvalues already onProductandPromotion(by usingallowed_ransackable_scopes).Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: