Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.3] Copy new migrations as part of the update task #4973

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Mar 9, 2023

Backport

This will backport the following commits from master to v3.3:

Questions ?

Please refer to the Backport tool documentation

Right now, we are not copying the new migrations
introduced with the new version. This new install
step will copy migrations and it's left to the
user to run db:migrate, before checking them.

This commit also update some copy of the task to
reflect the new content of the file.

(cherry picked from commit 241f6bc)
@github-actions github-actions bot requested a review from a team as a code owner March 9, 2023 09:12
@waiting-for-dev waiting-for-dev added the changelog:solidus_core Changes to the solidus_core gem label Mar 9, 2023
@waiting-for-dev waiting-for-dev changed the title [v3.3] Merge pull request #4957 from solidusio/kennyadsl/update-command [v3.3] Copy new migrations as part of the update task Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #4973 (521b4ad) into v3.3 (2e8fc57) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             v3.3    #4973   +/-   ##
=======================================
  Coverage   86.68%   86.69%           
=======================================
  Files         577      577           
  Lines       14664    14667    +3     
=======================================
+ Hits        12712    12715    +3     
  Misses       1952     1952           
Impacted Files Coverage Δ
.../lib/generators/solidus/update/update_generator.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@waiting-for-dev waiting-for-dev merged commit 0b76b39 into v3.3 Mar 9, 2023
@waiting-for-dev waiting-for-dev deleted the backport/v3.3/pr-4957 branch March 9, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants