Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in shipmnent.rb #5004

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

seand7565
Copy link
Contributor

Nothing to kick-start a Saturday like fixing a six year old typo

@seand7565 seand7565 requested a review from a team as a code owner April 1, 2023 22:28
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Apr 1, 2023
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #5004 (370ec0d) into master (b6f883e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5004   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files         580      580           
  Lines       14727    14727           
=======================================
  Hits        12764    12764           
  Misses       1963     1963           
Impacted Files Coverage Δ
core/app/models/spree/shipment.rb 93.45% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sean! 🙌

Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waiting-for-dev waiting-for-dev merged commit 813a9a1 into solidusio:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants