Allow to disable track inventory for product without variants #5039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow to disable track_inventory on the variant form, but not on the product form. This makes it impossible to change the value for sole products not having any variants, because the value is stored on the master variant.
github-actions
bot
added
changelog:solidus_backend
kennyadsl
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Thanks @tvdeyen! Not the best moment to merge this since we are releasing v4.0 and we would love it to only contain deprecation removals and breaking changes, but if we backport this to v3.4, this won't be a difference between v3.4.last and v4.0, so I think we can go ahead.
We actually delegate the value to the master variant and most stores will already have the translation present.
waiting-for-dev
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We allow to disable track_inventory on the variant form, but not on the product form. This makes it impossible to change the value for sole products not having any variants, because the value is stored on the master variant.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: