Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.1] Skip `ActionCable` for dummy apps #5630

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from main to v4.1:

Questions ?

Please refer to the Backport tool documentation

@github-actions github-actions bot requested a review from a team as a code owner January 25, 2024 15:17
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jan 25, 2024
@github-actions github-actions bot force-pushed the backport/v4.1/pr-5420 branch 2 times, most recently from 9b21950 to 7520161 Compare January 25, 2024 15:17
We don't really use ActionCable for anything as far as I know. Having it
makes installing Turbo/Stimulus in extensions harder.

The installer for Turbo will look for a Gemfile in `Rails.root`, which is not
there in case of the dummy app, and fail. If, however, `config/cable.yml` can't be
found, the Turbo installer succeeds with a message that Turbo is
installed, just without the broadcasting feature (which is alright for
most apps I believe).

(cherry picked from commit 3f8ad82)
@github-actions github-actions bot force-pushed the backport/v4.1/pr-5420 branch from 7520161 to 71352e6 Compare January 25, 2024 15:17
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
3 tasks
@tvdeyen
Copy link
Member

tvdeyen commented Jan 26, 2024

@mamhoff do you mind running rubocop -a on this?

@mamhoff
Copy link
Contributor

mamhoff commented Jan 26, 2024

I'm, unfortunately, not @github-actions...

@tvdeyen
Copy link
Member

tvdeyen commented Jan 26, 2024

will tackle linting in a seperate PR

@tvdeyen tvdeyen merged commit ceba4e8 into v4.1 Jan 26, 2024
6 of 7 checks passed
@tvdeyen tvdeyen deleted the backport/v4.1/pr-5420 branch January 26, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants