Deprecate Spree::Adjustment#recalculate

[mamhoff]

Summary

We've already deprecated Spree::Adjustment#calculate_eligibility, and we've removed all the code paths that call
Spree::Adjustment#recalculate. Let's deprecate it.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[mamhoff]

Requires #5633

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b46992) 88.56% compared to head (7ff5b8c) 88.56%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5632   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files         685      685           
  Lines       16408    16409    +1     
=======================================
+ Hits        14531    14532    +1     
  Misses       1877     1877           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kennyadsl]

👍 For when we're going to write the CHANGELOG for this, can we suggest any replacement for people who are using this method?

[mamhoff]

👍 For when we're going to write the CHANGELOG for this, can we suggest any replacement for people who are using this method?

In short, no.

Maybe you can formulate something like this:

We've deprecated using Spree::Adjustment#recalculate for recalculating adjustments. Instead, we want to treat adjustments as pure data objects, manipulated by service objects on order recalculation. See the implementations of Spree::OrderTaxation and Spree::Promotion::OrderAdjustmentsRecalculator on how adjustments should be recalculated instead.