Let promotion handler decide whether it can add a coupon to an order #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5684 +/- ##
=======================================
Coverage 88.90% 88.91%
=======================================
Files 700 700
Lines 16642 16647 +5
=======================================
+ Hits 14796 14801 +5
Misses 1846 1846 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
Mar 7, 2024
This new method allows the order to ask the coupon promotion handler whether an order can be modified with a promotion code.
Rather than directly referencing the Spree::Promotion ActiveRecord model, we ask the coupon code handler.
The core coupon promotion handler now has this method, so the null promotion handler needs it, too.
The four promotion handlers in core have two different methods to set them into motion. Cart, Shipping, and Page use #activate, but Coupon uses #apply. We only need one null promotion handler, and since we just want it to return the unchanged promotion, we just alias.
mamhoff
force-pushed
the
can-add-coupon-to-handler
branch
from
2cfcbfd to
b713be7
Compare
tvdeyen
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have the method
Spree::Order#can_add_coupon?that tells us whether an order can even accept a promotion code. Unfortunately, it directly references theSpree::Promotionclass that is slated to be moved tosolidus_legacy_promotions. Rather than adding a new class, I add another method to the coupon promotion handler class that does this.I'm also adding the same method to the
NullPromotionHandlerfor API parity.Lastly, I realized that not all promotion handlers in core share the same API, so I alias
activatetoapplyso that theNullPromotionHandlercan be a stand-in for all promotion handlers.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: