Fix flaky admin stock items spec #5701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to jump through all kinds of hoops to do this otherwise. Just give the count on hand to the factory.
This spec was flaky, as it generated potentially multiple SKUs per variant, and it generated them implicitly. These changes makes everything very explicit, such that we get exactly one stock item per variant with an identifiable name.
github-actions
bot
added
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5701 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 700 700
Lines 16653 16655 +2
=======================================
+ Hits 14808 14810 +2
Misses 1845 1845 ☔ View full report in Codecov by Sentry. |
mamhoff
changed the title
tvdeyen
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This spec failed on me a number of times over the past week, so we spent some time hardening it. Super cool extra feature: We can now create a stock item with a desired on-hand quantity from within the stock item factory!
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: