NullPromotionHandler: return self from #apply #5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5767 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 711 711
Lines 16885 16886 +1
=======================================
+ Hits 15013 15014 +1
Misses 1872 1872 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
May 30, 2024
mamhoff
force-pushed
the
null-promo-handler-return-value
branch
from
9ba5198 to
74dd96e
Compare
The existing promotion handlers are activated using either `#apply` or `#activate`. The return value `#activate` is usually not read, and is thus not really important, but that of `#apply` must be the handler itself, so that e.g. the adjustments admin has access to any application errors.
mamhoff
force-pushed
the
null-promo-handler-return-value
branch
from
74dd96e to
fd5d77e
Compare
github-actions
bot
added
the
changelog:solidus_core
tvdeyen
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing promotion handlers are activated using either
#applyor#activate. The return value#activateis usually not read, and is thus not really important, but that of#applymust be the handler itself, so that e.g. the adjustments admin has access to any promotion application errors.