Create custom orders index component for solidus_legacy_promotions #5779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
legacy-promotions-orders-index
branch
from
d29d00b to
972e89f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5779 +/- ##
=======================================
Coverage 88.87% 88.88%
=======================================
Files 711 712 +1
Lines 16885 16892 +7
=======================================
+ Hits 15007 15014 +7
Misses 1878 1878 ☔ View full report in Codecov by Sentry. |
|
It's wonderful seeing this used. cc @elia @rainerdema 👏 And thanks @mamhoff! |
adammathys
approved these changes
Jun 6, 2024
The new admin allows orders to be filtered by promotion name. However, with the legacy promotion system extracted into an extension, we can't rely on `Spree::Promotion` to exist in `solidus_admin`. In order to get around this issue, we create a new index component for the admin orders page that includes the filter, and register it in an initializer. This also adds a spec for filtering by promotion name.
mamhoff
force-pushed
the
legacy-promotions-orders-index
branch
from
972e89f to
79c1195
Compare
kennyadsl
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new admin allows orders to be filtered by promotion name. However, with the legacy promotion system extracted into an extension, we can't rely on
Spree::Promotionto exist insolidus_admin. In order to get around this issue, we create a new index component for the admin orders page that includes the filter, and register it in an initializer.This also adds a spec for filtering by promotion name.