Move promotion code batch services #5787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
mamhoff
force-pushed
the
move-promotion-code-batch-services
branch
2 times, most recently
from
31fc542 to
066f6c4
Compare
We need to temporarily freedom-patch Spree::PromotionCodeBatch, because the model class needs to stay in Solidus Core, but the tests, jobs and mailers are already in `solidus_legacy_promotions`. Once everything is moved, we can merge the model and the decorator again.
mamhoff
force-pushed
the
move-promotion-code-batch-services
branch
from
066f6c4 to
d293d0d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5787 +/- ##
==========================================
- Coverage 88.72% 88.72% -0.01%
==========================================
Files 712 713 +1
Lines 16914 16917 +3
==========================================
+ Hits 15007 15009 +2
- Misses 1907 1908 +1 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves the PromotionCodeBatchMailer and the PromotionCodeBatchJob to
solidus_legacy_promotions. I want to have the service objects over before moving all the models. Unfortunately, the model here interacts heavily with the services, so I need to extract one method to a decorator that will disappear once the rest of the models have moved.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: