Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4] Backend: Add missing error translation #5986

Merged
merged 1 commit into from
Dec 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Backend: Add missing error translation
We were missing a translation here, but never noticed, because we were
not testing for an actual human-understandable string.

This is broken in the v4.0, v4.1, v4.2 and v4.3 branches with a noisier
error message, because in those branches, `I18n.t("unavailable")` is
different from `t("unavailable")`.

(cherry picked from commit 506ddfc)
mamhoff committed Dec 3, 2024
commit f9d75870876726e74452c69fcaf96e361d0669c5
Original file line number Diff line number Diff line change
@@ -505,7 +505,7 @@ def user

it "cannot be destroyed" do
is_expected.to be_forbidden
expect(subject.body).to eq I18n.t("spree.error_user_destroy_with_orders")
expect(subject.body).to eq("Cannot delete a user with orders")
end
end
end
1 change: 1 addition & 0 deletions core/config/locales/en.yml
Original file line number Diff line number Diff line change
@@ -1516,6 +1516,7 @@ en:
end: End
ending_in: Ending in
error: error
error_user_destroy_with_orders: Cannot delete a user with orders
errors:
messages:
cannot_delete_finalized_stock_location: Stock Location cannot be destroyed if you have open stock transfers.