Allow admins to reset an user's password through the admin panel #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitbw
force-pushed
the
aitbw/admins-password-reset
branch
from
c49d61d to
1efba33
Compare
jacobherrington
previously approved these changes
Apr 9, 2019
jacobherrington
dismissed
their stale review
I'd like to see the conflict fixed before approving this PR.
|
Hey, @aitbw would you mind rebasing this to fix the conflicts? |
aitbw
force-pushed
the
aitbw/admins-password-reset
branch
from
1efba33 to
c4b22ea
Compare
|
Done @jacobherrington, sorry on the delay! Please refer to #165 for CI fixes 🙌 |
aitbw
force-pushed
the
aitbw/admins-password-reset
branch
from
c4b22ea to
5afa3d9
Compare
app/overrides/spree/admin/users/edit/_add_reset_password_form.html.erb.deface
Outdated
Show resolved
Hide resolved
PR solidusio#156 changed the I18n value for the text shown when an admin resets their password
aitbw
force-pushed
the
aitbw/admins-password-reset
branch
from
5afa3d9 to
e79ff3e
Compare
|
Done @spaghetticode ! ✔️ |
This was referenced Oct 23, 2019
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to serve as a starting point to finally close one of Solidus' oldest issues (solidusio/solidus#438) by adding a "Reset password" button/form admins can use to reset an user's password if necessary. It supeseeds PRs solidusio/solidus#1942 and solidusio/solidus#3151
Said button/form only renders if the user being modified is not the same as the one currently logged-in, as it makes no sense an admin would reset their own password through the admin panel.
This PR also re-introduces Deface (see #114), which might be the most sensible change included in this patch, but it's preferable than entirely overriding a view, as it might be modified in some way by another Solidus extension or the stores themselves.