Migrate database by default #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to migrate the database by default so that once we add Braintree to the Solidus installer, running `solidus:install` would automatically run the SolidusBraintree migrations. See solidusio/solidus#4749. This should be safe since migrate is also enabled by default in SolidusPaypalCommercePlatform. See https://github.com/solidusio/solidus_paypal_commerce_platform/blob/a6f87f5d6a1621eda453db31ccdc8c3903ef48c4/lib/generators/solidus_paypal_commerce_platform/install/install_generator.rb#L6.
elia
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to migrate the database by default so that once we add Braintree to the Solidus installer, running
solidus:installwould automatically run the SolidusBraintree migrations. See solidusio/solidus#4749.This should be safe since migrate is also enabled by default in SolidusPaypalCommercePlatform. See
https://github.com/solidusio/solidus_paypal_commerce_platform/blob/a6f87f5d6a1621eda453db31ccdc8c3903ef48c4/lib/generators/solidus_paypal_commerce_platform/install/install_generator.rb#L6.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: