Merge pull request #106 from seand7565/fix_linter

Update specs to comply with new rubocop regulations

spec/lib/solidus_paypal_commerce_platform/client_spec.rb

@@ -10,7 +10,7 @@
     let(:status_code) { 201 }
 
     it 'forwards to the upstream client adding i18n response messages' do
-      expect_any_instance_of(PayPal::PayPalHttpClient)
+      allow_any_instance_of(PayPal::PayPalHttpClient)
         .to receive(:execute).with(paypal_request).and_return(paypal_response)
 
       response = subject.execute_with_response(paypal_request)

spec/lib/solidus_paypal_commerce_platform/configuration_spec.rb

@@ -12,16 +12,16 @@
     it "falls back to Rails.env if ENV['PAYPAL_ENV'] is not set" do
       expect(ENV).to receive(:[]).with("PAYPAL_ENV").and_return(nil).at_least(:once)
 
-      expect(Rails).to receive(:env).and_return("development".inquiry)
+      allow(Rails).to receive(:env).and_return("development".inquiry)
       expect(subject.default_env).to eq("sandbox")
 
-      expect(Rails).to receive(:env).and_return("test".inquiry)
+      allow(Rails).to receive(:env).and_return("test".inquiry)
       expect(subject.default_env).to eq("sandbox")
 
-      expect(Rails).to receive(:env).and_return("production".inquiry)
+      allow(Rails).to receive(:env).and_return("production".inquiry)
       expect(subject.default_env).to eq("live")
 
-      expect(Rails).to receive(:env).and_return("staging".inquiry)
+      allow(Rails).to receive(:env).and_return("staging".inquiry)
       expect{ subject.default_env }.to raise_error(described_class::InvalidEnvironment)
     end
   end