Add ability for admin users to customize paypal button #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
reviewed
Jun 1, 2020
lib/views/backend/spree/admin/shared/preference_fields/_paypal_select.html.erb
Outdated
Show resolved
Hide resolved
seand7565
force-pushed
the
customize_buttons
branch
from
8d7f153 to
e270f99
Compare
elia
approved these changes
Jun 4, 2020
elia
added
paypal onboarding
I utilize the preference_fields, creating a custom one for a select option. I also provide defaults for all of the button options based on the defaults PayPal recommends selecting, while adding a helper that provides the collection of other available options. All of this is displayed on the PCP payment method page on admin. The options are passed on the frontend when we display the PayPal button.
seand7565
force-pushed
the
customize_buttons
branch
from
e270f99 to
21316be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I utilize the preference_fields, creating a custom one for a select option. I also provide defaults for
all of the button options based on the defaults PayPal recommends selecting, while adding a helper
that provides the collection of other available options. All of this is displayed on the PCP
payment method page on admin. The options are passed on the frontend when we display the PayPal button.
NOTE: This PR requires #10 to be merged first, as it adds some options to the frontend button that that PR adds. Once #10 is merged, I'll rebase this PR and it should be good to go!
Ref: #5