Display paypal email to customer on confirmation #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to store the paypal email on the payment source, which will allow us to display this email to the customer on the confirmation page - which is in PayPals best practices.
Adds paypal_email to allowed source attributes and passes the paypal_email returned from PayPal to source creation for both cart and checkout payment flows
elia
approved these changes
Jul 7, 2020
lib/views/frontend/solidus_paypal_commerce_platform/payments/_payment.html.erb
Outdated
Show resolved
Hide resolved
Displays the collected paypal_email (stored on the source) to the user on the order confirmation page.
The admin users could find this useful for debugging possible payment issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #47 states, we need to display the users paypal email to the customer on the confirmation page. This handles that! Also, displays the paypal_email to admin users as well, since that could come in handy.