Add better error handling to button_actions.js #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if an error occurred in the send_order function - like if the order does not total up correctly - the user would see the PayPal loading screen forever. This handles the error - closing the PayPal screen when they occur - and logging the error + debug ID both to console and to the Rails logger. This also ensures that an address is rejected if there is an issue sending the updated order details to PayPal, otherwise PayPal would allow paying for an order with address issues.
elia
approved these changes
Aug 12, 2020
| console.log("PayPal Debug ID: " + error.debug_id) | ||
| alert("There was a problem connecting with PayPal.") | ||
| } | ||
|
|
There was a problem hiding this comment.
❤️ This is great for capturing errors with error-tracking services!
| actions.order.patch([response]); | ||
| }); | ||
| actions.order.patch([response]).catch(function() { | ||
| actions.reject() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an error occurred in the send_order function - like if
the order does not total up correctly - the user would see the PayPal
loading screen forever. This handles the error - closing the PayPal screen
when they occur - and logging the error + debug ID both to console and to
the Rails logger. This also ensures that an address is rejected if there is
an issue sending the updated order details to PayPal, otherwise PayPal would
allow paying for an order with address issues.