Utilize Devise Location helpers #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpfergus1
force-pushed
the
connorferguson/sol-306-deprecate-redirect_back_or_default
branch
from
8c53471 to
e21fb59
Compare
cpfergus1
force-pushed
the
connorferguson/sol-306-deprecate-redirect_back_or_default
branch
from
e21fb59 to
6730c5d
Compare
cpfergus1
changed the title
7 tasks
|
Why still draft? |
This requires solidusio/solidus_auth_devise#228 to be merged first |
cpfergus1
force-pushed
the
connorferguson/sol-306-deprecate-redirect_back_or_default
branch
from
5e8ca33 to
2f7fbe0
Compare
With the deprecation of #redirect_back_or_default in solidus 4.0, we can utilize the SolidusAuthDevise helper stored_location_for to provide the same functionality.
This method was utilized for redirect_back_or_default. It is no longer required
cpfergus1
force-pushed
the
connorferguson/sol-306-deprecate-redirect_back_or_default
branch
from
2f7fbe0 to
da6c517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes #redirect_back_or_default in favor of solidus_auth_devise helper methods
Motivation and Context
The method #redirect_back_or_default and the class user_last_url_storer will be deprecated in Solidus solidusio/solidus#4533 which would break the current build without these changes. SolidusAuthDevise has similar a helper method to #redirect_back_or_default, #stored_spree_user_location_or which was introduced in solidus_auth_devise PR228 and will be utilized instead.
How Has This Been Tested?
The current test suite covers the changes made in the PR
Types of changes
Bug fix (non-breaking change which fixes an issue)New feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist: