Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ViewComponent to v3 #343

Merged
merged 2 commits into from
May 29, 2023
Merged

Bump ViewComponent to v3 #343

merged 2 commits into from
May 29, 2023

Conversation

elia
Copy link
Member

@elia elia commented May 26, 2023

Summary

Fixes #342

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this May 26, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #343 (bb1f2a0) into main (b9a02e1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   97.13%   97.11%   -0.02%     
==========================================
  Files         190      190              
  Lines        4500     4479      -21     
==========================================
- Hits         4371     4350      -21     
  Misses        129      129              
Impacted Files Coverage Δ
template.rb 84.93% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review May 29, 2023 11:13
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tacking this one! 🙂

@elia elia merged commit 9c27457 into main May 29, 2023
@elia elia deleted the elia/vc3 branch May 29, 2023 12:10
waiting-for-dev added a commit to solidusio/solidus that referenced this pull request May 31, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
waiting-for-dev added a commit to solidusio/solidus that referenced this pull request Jun 1, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
waiting-for-dev added a commit to solidusio/solidus that referenced this pull request Jun 5, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Jun 5, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Jun 9, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Jun 9, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Jun 19, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Jul 11, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Aug 2, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
waiting-for-dev added a commit to solidusio/solidus that referenced this pull request Aug 8, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
waiting-for-dev added a commit to solidusio/solidus that referenced this pull request Aug 9, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Sep 25, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Sep 27, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Sep 28, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Sep 29, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
rainerdema pushed a commit to nebulab/solidus that referenced this pull request Sep 29, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
elia pushed a commit to solidusio/solidus that referenced this pull request Oct 6, 2023
We need to bump CircleCI cache to fetch latest changes on SSF allowing
view_components v3 (see
solidusio/solidus_starter_frontend#343).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to view_components v3
3 participants