Do not reset spree preferences starting from v2.9 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spaghetticode can you please review? |
spaghetticode
approved these changes
Jul 18, 2019
kennyadsl
changed the title
|
Better to wait for solidusio/solidus#3275, which could change the signature of the |
Using this method in extensions (and stores) allows to set preferences by stubbing them as suggested in core. Using this helper guarantee to have it working also in past Solidus versions, where stub_spree_preferences method does not exist yet.
kennyadsl
force-pushed
the
kennyadsl/reset_preferences
branch
from
f48aab6 to
097e8fb
Compare
|
I tried this branch in a real extension (solidusio/solidus_auth_devise#166), waiting for the CI to run before merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to remove deprecation warnings into extensions. Of course, this could let some spec fail on 2.9 or master.
This PR stops resetting preferences after each spec run and provides an alternative method to use into extensions (and stores) specs. This method will work for all supported Solidus versions and it will be easy to remove later since they have the same signature: we can just remove the
require 'solidus_support/testing_support/preferences'for solidus supportrails_helperwithout any change in the extensions.