Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the new dev_tools gem name in rubocop config #36

Closed
wants to merge 1 commit into from
Closed

Switch to the new dev_tools gem name in rubocop config #36

wants to merge 1 commit into from

Conversation

kennyadsl
Copy link
Member

It has been renamed recently and it was added twice. I removed the Gemfile's dependency, which is not needed anymore.

@kennyadsl kennyadsl requested review from aldesantis and a team December 18, 2019 17:19
@kennyadsl kennyadsl self-assigned this Dec 18, 2019
tvdeyen
tvdeyen reviewed Dec 18, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it makes sense to host this gem also under the core solidus organization as with solidus_support?

spaghetticode
spaghetticode approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 👍

@spaghetticode spaghetticode mentioned this pull request Dec 19, 2019
Merged
@kennyadsl kennyadsl force-pushed the kennyadsl/use-solidus-dev-support branch from b54c477 to 9725cbe Compare January 14, 2020 13:32
@kennyadsl
Switch to the new dev_tools gem name in rubocop config
246d89d 
It has been renamed recently and it was added twice.
I removed the Gemfile's dependency, which is not needed anymore.
@kennyadsl kennyadsl force-pushed the kennyadsl/use-solidus-dev-support branch from 9725cbe to 246d89d Compare January 14, 2020 13:34
@kennyadsl kennyadsl changed the title Switch to the new dev_tools gem name Switch to the new dev_tools gem name in rubocop config Jan 14, 2020
@kennyadsl
Copy link
Member Author

@tvdeyen

Would it makes sense to host this gem also under the core solidus organization as with solidus_support?

Yes, but we'd wait until an initial version is ready, a lot of things are changing too fast and it's probably better to avoid waiting for core approvals policies here for now. Once in an advanced state we can easily move it under solidusio, wdyt?

@aldesantis
Copy link
Member

@kennyadsl superseded by #41. 🙏

@aldesantis aldesantis closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen left review comments

@spaghetticode spaghetticode spaghetticode approved these changes

@elia elia elia approved these changes

@aldesantis aldesantis Awaiting requested review from aldesantis

Assignees

@kennyadsl kennyadsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennyadsl @aldesantis @elia @tvdeyen @spaghetticode