Use Spree::Event. activate_all_subscribers when available
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jarednorman
approved these changes
Sep 25, 2020
The new method `Spree::Event.activate_all_subscribers` is introduced in Solidus with solidusio/solidus#3758 as a better way to subscribe event subscribers. Under the hood, event subscribers use new interal mappings. Also, we need to keep around the old interface as well until it won't be supported anymore in Solidus.
spaghetticode
force-pushed
the
spaghetticode/new-event-subscribers-mappings
branch
from
78cc32a to
5b52ea7
Compare
spaghetticode
changed the title
Spree::Event.subscribe_subscribers! when availableSpree::Event. activate_all_subscribers when available
kennyadsl
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new method
Spree::Event. activate_all_subscribersis introduced in Solidus with solidusio/solidus#3758 as a better way to subscribe event subscribers: under the hood, event subscribers use new internal mappings.Also, we need to keep around the old interface as well until it won't be supported anymore in Solidus.
For more details about the mappings change see solidusio/solidus#3757