Client type #21
Open
Client type #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt into type/utils
sologenic
suggested changes
Apr 20, 2020
| * Type of client application using Sologenic Tx Handler | ||
| */ | ||
| protected clientType: string = 'mobile'; | ||
|
|
There was a problem hiding this comment.
default should not be mobile. Leave it as an empty string
src/lib/txhandler.ts
Outdated
| @@ -115,7 +120,8 @@ export class SologenicTxHandler extends EventEmitter { | |||
| */ | |||
| constructor( | |||
| rippleApiOptions: SologenicTypes.RippleAPIOptions, | |||
| sologenicOptions: SologenicTypes.TransactionHandlerOptions | |||
| sologenicOptions: SologenicTypes.TransactionHandlerOptions, | |||
There was a problem hiding this comment.
why don't we include the client options in SologenicOptions? I don't see why we need to have the third type. We can just easily add a property in sologenicOptions.
|
|
||
| if (typeof clientOptions.clientType !== 'undefined') { | ||
| this.clientType = clientOptions.clientType; | ||
| } |
There was a problem hiding this comment.
in the proposed scenario you can just use:
if (typeof clientOptions.clientType !== 'undefined') {
this.clientType = sologenicOptions.clientType;
}
added 2 commits
April 20, 2020 15:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
A feature change: add a new variable, clientType, to know the type of client (e.g. mobile, desktop, etc.)
What is the current behavior? (You can also link to an open issue here)
None
What is the new behavior (if this is a feature change)?
This change is adding the new variable: clientType in Sologenic Tx Handler and adding a new interface Client in types/utils.
Initializing the constructor in Sologenic Tx Handler, the clientType is initialized.
Other information:
clientType is 'mobile' by default.