Allow interactive PIN entry for solo key verify.
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enrikb
force-pushed
the
feature/verify_ask_for_pin_if_required
branch
from
c77f10e to
7e06567
Compare
|
Reworked to use FIDO2 info indication to tell if PIN is required. |
The PIN will be requested interactively if the Fido2 info indicates a PIN is set and none has been given on the command line.
nickray
force-pushed
the
feature/verify_ask_for_pin_if_required
branch
from
7e06567 to
dffad03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While still allowing to pass
--pin <pin>like some of the other commands, do no longer suggest it.The solution is a bit hacky, calling
verifyrecursively a second time iff a PIN is required but was not set before.The 'Please press the button on your Solo key' is also not very consistently repeated, but it is also output a little inconsistently before this change.