Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Mark as abandoned #402

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Mark as abandoned #402

merged 1 commit into from
Dec 9, 2021

Conversation

VincentLanglet
Copy link
Member

No description provided.

@VincentLanglet VincentLanglet requested a review from a team December 5, 2021 17:06
Copy link
Member

@core23 core23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too soon. We still use this for the page bundle

@VincentLanglet
Copy link
Member Author

Too soon. We still use this for the page bundle

We're using GoogleAuthenticator in SonataUser and still we mark it as abandoned.
This PR is made to communicating about the fact we're deprecating/abandoning this lib.
It's still on dev-kit for now.

it's not because the PageBundle use a deprecated library (and should remove the dependency) that the library is not deprecated.

@jordisala1991
Copy link
Member

We should do a last release to fix a bug and add support for sf 6 before deprecating

@VincentLanglet
Copy link
Member Author

#404

@VincentLanglet VincentLanglet merged commit c4d5816 into 3.x Dec 9, 2021
@VincentLanglet VincentLanglet deleted the markAbandon branch December 9, 2021 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants