Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some API violations #359

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Fix some API violations #359

merged 1 commit into from
Apr 14, 2020

Conversation

phansys
Copy link
Member

@phansys phansys commented Apr 9, 2020 •
edited
Loading

Subject

Fix some API violations

I am targeting this branch, because these changes respect BC.

Changelog

### Fixed
- Fixed returning `void` from methods which are intended to return values and returning values from methods which are intended to return `void`;
- Fixed weak check at `ModelManager::getNormalizedIdentifier()`.

@phansys phansys added the patch label Apr 9, 2020
@phansys phansys requested a review from a team April 10, 2020 01:30
@phansys phansys marked this pull request as ready for review April 10, 2020 01:30
core23
core23 previously approved these changes Apr 10, 2020
View reviewed changes
@phansys phansys requested a review from VincentLanglet April 10, 2020 14:00
VincentLanglet
VincentLanglet previously approved these changes Apr 10, 2020
View reviewed changes
@phansys phansys requested a review from core23 April 10, 2020 14:08
OskarStark
OskarStark previously approved these changes Apr 13, 2020
View reviewed changes
greg0ire
greg0ire reviewed Apr 13, 2020
View reviewed changes
@greg0ire greg0ire merged commit 0238da9 into sonata-project:3.x Apr 14, 2020
@greg0ire
Copy link
Contributor

Thanks @phansys !

@phansys phansys deleted the api_fixes branch April 14, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@core23 core23 Awaiting requested review from core23

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phansys @greg0ire @OskarStark @core23 @VincentLanglet