Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 6 Support #1675

Closed
36 tasks done
jordisala1991 opened this issue Sep 17, 2021 · 12 comments · Fixed by #1926
Closed
36 tasks done

Symfony 6 Support #1675

jordisala1991 opened this issue Sep 17, 2021 · 12 comments · Fixed by #1926

Comments

@jordisala1991
Copy link
Member

jordisala1991 commented Sep 17, 2021

Active Bundles

Bundles that are used as dependencies

Bundles that do not support SF 5

  • SonataPageBundle

Bundles with only Symfony dependencies on require-dev section

Final cleanup

The final step is cleanup composer.json and make sure all builds pass without requiring unstable dependencies

  • SonataAdminBundle
  • SonataDoctrineMongoDBAdminBundle
  • SonataDoctrineORMAdminBundle
  • SonataSeoBundle
  • SonataTranslationBundle
  • SonataClassificationBundle
  • SonataMediaBundle
  • SonataUserBundle
  • SonataFormatterBundle
  • SonataBlockBundle
  • exporter
  • form-extensions
  • twig-extensions
  • EntityAuditBundle
  • SonataIntlBundle
  • SonataDatagridBundle
@wbloszyk
Copy link
Member

wbloszyk commented Oct 3, 2021

Can you add Support for Symfony 5 section too?

@jordisala1991
Copy link
Member Author

I think there was an issue about sf 5.

@jordisala1991
Copy link
Member Author

@franmomu do you have time for help with DoctrineMongoDBAdminBundle?

@jordisala1991
Copy link
Member Author

SonataSeoBundle is ready too, @Kocal if you want to help with it

@Kocal
Copy link

Kocal commented Oct 27, 2021

Gonna give it a try this evening!

@jordisala1991
Copy link
Member Author

jordisala1991 commented Nov 5, 2021

We are stuck because of the panther 🐈‍⬛ ...

Persistence bundles require it: sonata-project/SonataDoctrineORMAdminBundle#1562
It does not have support: symfony/panther#509
It cant be easily added because it requires changes on the main Symfony or a new major version: symfony/symfony#43021 (comment)

Options:

  1. We do nothing and wait (we will not be day 1 compatible with Symfony 6, which would have been a huge success, and a selling point)
  2. We try to remove symfony/panther from 6.0 build until it gets fixed (not sure if it can be done)
  3. We get rid of Symfony Panther (not a good idea IMO, it is useful to test with JS)

What should we do? @sonata-project/contributors

@jordisala1991
Copy link
Member Author

jordisala1991 commented Nov 30, 2021

The final step is cleanup composer.json and make sure all builds pass without requiring unstable dependencies. I have started with exporter and form-extensions, any help welcome @sonata-project/contributors

@jordisala1991
Copy link
Member Author

Symfony Security Acl is blocking the update to Symfony 6 , we might take a look and help them with that, otherwise our users cant update. symfony/security-acl#99

@VincentLanglet
Copy link
Member

Symfony Security Acl is blocking the update to Symfony 6 , we might take a look and help them with that, otherwise our users cant update. symfony/security-acl#99

Will be solved by symfony/security-acl#100 :)

@jordisala1991
Copy link
Member Author

We are still blocked by the symfony acl :(

@jordisala1991
Copy link
Member Author

We are unblocked, tomorrow will try to check and fix SonataAdminBundle build.

We need to check all builds and remove the usage of unstable dependencies.

@jordisala1991
Copy link
Member Author

So all bundles are cleaned up, we just need a dev-kit PR.

@jordisala1991 jordisala1991 linked a pull request Feb 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants