This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 69
Add Symfony 6 support #385
Merged
jordisala1991
merged 6 commits into
sonata-project:3.x
from
jordisala1991:feature/symfony-6
Dec 8, 2021
Merged
Add Symfony 6 support #385
jordisala1991
merged 6 commits into
sonata-project:3.x
from
jordisala1991:feature/symfony-6
Dec 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocked by: doctrine/phpcr-odm |
36 tasks
They only use symfony/console and symfony/yaml, maybe the PR could be easy. |
Could you please rebase your PR and fix merge conflicts? |
Waiting for doctrine/phpcr-odm#822 |
Since this package is deprecated, this might be not worthy to add SF6 @jordisala1991 |
phpcr-odm symfony 6 support is tagged as https://github.com/doctrine/phpcr-odm/releases/tag/1.6.0 |
jordisala1991
force-pushed
the
feature/symfony-6
branch
from
December 8, 2021 10:04
5ac130e
to
ce1878a
Compare
jordisala1991
force-pushed
the
feature/symfony-6
branch
from
December 8, 2021 10:04
ce1878a
to
d78abfd
Compare
Since it is that easy to add support I think it is better to add it to not have blockers for PageBundle. |
VincentLanglet
approved these changes
Dec 8, 2021
core23
approved these changes
Dec 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC.
Part of: sonata-project/dev-kit#1675
Dev-kit PR: sonata-project/dev-kit#1816
Changelog