Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Add Symfony 6 support #385

Merged
merged 6 commits into from
Dec 8, 2021

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Nov 12, 2021

Subject

I am targeting this branch, because this is BC.

Part of: sonata-project/dev-kit#1675
Dev-kit PR: sonata-project/dev-kit#1816

Changelog

### Added
- Added support for Symfony 6.
### Removed
- Removed support for Symfony 5.2.
- Removed support for PHP < 7.3.

@jordisala1991
Copy link
Member Author

Blocked by: doctrine/phpcr-odm

@VincentLanglet
Copy link
Member

doctrine/phpcr-odm

They only use symfony/console and symfony/yaml, maybe the PR could be easy.
If not, we might consider adding the support to at least not block orm or mongo.

@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@VincentLanglet
Copy link
Member

Waiting for doctrine/phpcr-odm#822

@VincentLanglet
Copy link
Member

Since this package is deprecated, this might be not worthy to add SF6 @jordisala1991

@dbu
Copy link
Contributor

dbu commented Dec 7, 2021

phpcr-odm symfony 6 support is tagged as https://github.com/doctrine/phpcr-odm/releases/tag/1.6.0

@jordisala1991 jordisala1991 marked this pull request as ready for review December 8, 2021 10:04
@jordisala1991 jordisala1991 requested review from VincentLanglet and a team December 8, 2021 10:08
@jordisala1991
Copy link
Member Author

Since this package is deprecated, this might be not worthy to add SF6 @jordisala1991

Since it is that easy to add support I think it is better to add it to not have blockers for PageBundle.

@jordisala1991 jordisala1991 merged commit fcde2f7 into sonata-project:3.x Dec 8, 2021
@jordisala1991 jordisala1991 deleted the feature/symfony-6 branch December 8, 2021 12:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants