Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Make Scala Container attribute update API-compliant #32

Merged
merged 2 commits into from
Sep 16, 2014

Conversation

huitseeker
Copy link
Contributor

Works on the sample projects.

Mitigates #30 (please refer to individual commit message)

Mitigates sonatype#30, though this is probably not sufficient
(the raw classpath is being overwritten in other places).

review by @davidB.
@huitseeker huitseeker changed the title Make Scala Continer attribute update API-compliant Make Scala Container attribute update API-compliant Sep 16, 2014
davidB added a commit that referenced this pull request Sep 16, 2014
Make Scala Container attribute update API-compliant
@davidB davidB merged commit cc32ef1 into sonatype:master Sep 16, 2014
@davidB
Copy link
Contributor

davidB commented Sep 16, 2014

I'm not the author of the original code about deployable Attribute, and I'm not a WTP user (main target of the original code). So I can't fully test it. But I trust huitseeker (member of scala-ide).

I'll try the code my samples and a new one with scala 2.10/2.11 to test it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants