Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sai-gen] Update SAI API header file generation to use SAI spec #578

Merged
merged 16 commits into from
Jun 21, 2024

Conversation

r12f
Copy link
Collaborator

@r12f r12f commented Jun 2, 2024

Moving SAI API header file generation from using the P4 table information to SAI spec.

This change contains several minor fixes to the SAI specs:

  • Description and comment generation with respect to the SAI acronyms.
  • Fixed SAI flags and default values.
  • Added missing SAI attributes that is generated from table keys.
  • Fixed valid only tag generation.
  • Fixed unwanted header files for underlay.

Some typical changes (all comment changes, APIs are not changed and kept in the same order):

image

image

@r12f r12f force-pushed the user/r12f/header branch from 7b9ace2 to d9695c3 Compare June 18, 2024 21:39
@r12f r12f changed the title [sai-gen] Update SAI API header file generation to use SAI spec (Pending #576) [sai-gen] Update SAI API header file generation to use SAI spec Jun 18, 2024
@r12f r12f marked this pull request as ready for review June 18, 2024 21:45
@r12f r12f requested review from marian-pritsak and Pterosaur June 18, 2024 21:45
@r12f
Copy link
Collaborator Author

r12f commented Jun 21, 2024

adding Ze into review, since his DPU image work is getting affected if the SAI API is not backward compatible.

@r12f
Copy link
Collaborator Author

r12f commented Jun 21, 2024

@Pterosaur , without this change, the header generation will remain broken.

@r12f r12f merged commit f4c0735 into sonic-net:main Jun 21, 2024
4 checks passed
@r12f r12f deleted the user/r12f/header branch June 21, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants