SONiC bulk counter support #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyzhai
reviewed
May 31, 2022
jimmyzhai
reviewed
May 31, 2022
jimmyzhai
reviewed
May 31, 2022
jimmyzhai
reviewed
May 31, 2022
jimmyzhai
reviewed
Jun 13, 2022
jimmyzhai
reviewed
Jun 13, 2022
jimmyzhai
reviewed
Jun 13, 2022
jimmyzhai
reviewed
Jun 13, 2022
jimmyzhai
reviewed
Jun 13, 2022
|
|
||
| ##### Statistic Collect | ||
|
|
||
| . |
There was a problem hiding this comment.
- If mode SAI_STATS_MODE_BULK_READ_AND_CLEAR is supported, call sai_bulk_object_get_stats is enough. I think it is equative to sai_bulk_object_get_stats(mode=BULK_READ) and then sai_bulk_object_clear_stats(mode=BULK_CLEAR).
- If not sucess after sai_bulk_object_get_stats or sai_bulk_object_clear_stats, why go to 'Old way'?
There was a problem hiding this comment.
- yes, you are right
- we need keep backward compatible
There was a problem hiding this comment.
Shall we fall back to old way?
|
For performance improvement, do you have any raw data in your prototype to estimate how much the gain is for bulk get vs get? |
|
@kcudnik please review it. |
Add a performance section to describe the performance improvement. |
kcudnik
reviewed
Jun 14, 2022
jimmyzhai
approved these changes
Jun 21, 2022
kcudnik
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR https://github.com/opencomputeproject/SAI/pull/1352/files introduced new SAI APIs that supports bulk stats:
SONiC flex counter infrastructure shall utilize bulk stats API to gain better performance. This document discusses how to integrate these two new APIs to SONiC.
Related PRs: