-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clock commands management HLD #1219
Conversation
Initial doc for HLD
Updated final version for review
Updated validation and NTP interop comments
The HLD is reviewed in SONiC community meeting on 1/17/2023 |
Please remember to update https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md with the new CLIs |
typos fix
Update HLD to community with all comments recieved.
added additional tests
small alignment
@venkatmahalingam, @madhupalu @bsun-sudo @dharmaraj-gurusamy HLD is updated based on comments provided, please review and let us know if you have any further concern. if not please approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved the HLD with the suggestion to fine tune the logic for upgrade scenario.
adjusted the HLD with the exact cli wording implementation.
changed the examples according to exact implementation.
@yxieca @madhupalu when do you expect to complete the code review? we want to merge it before the branching out happens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing the comments
Added test pass criteria to relevant tests.
…into clock-commands
1db60fd
PR is now merged. as the feature is planed for 202305 appreciate code PR review and feedback to be able not to skip the release timeline. |
@Meir-renford @fastiuk the code PRs description is not aligned with the PR subjects. Can you please align? |
This is a PR for community review of clock commands management high level design.