Silicon config support for Broadcom yml file and property overwrite

[geans-pin]

Module name	PR	State
sonic-buildimage	Common Config Update
sonic-sairedis	Modify syncd script to support yml

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: geans-pin / name: 賓少鈺 (7f344a4, 45aa3e0, fbcbf73, effd3cd, 7cd8596, fdffbfd, 1c69d91, 3678e95, a65543a, e5ce48a, 017b949, 94ae80d, 7bfd8e7)

[ZhaohuiS]

@geans-pin
After last meeting, we have the following comments for the new design:

• Add flag/option to allow vendor's config.bcm to override common (current behavior), but it could support to common config.bcm to override vendor's config.bcm to give better control.

First, we extract the common attributes from platform config.bcm. If it's a common config for all HWSKUs of one type of ASIC, we have to remove it from platform specific config.bcm and only keep it in common config.bcm,

It could give us a better control that we can just modify one place to sync one config change for all related HWSKUs, don't have to update platform specific config.bcm one by one.

Second, since this a huge change for config.bcm which is critical file for SAI, could you please cover how to do unit test in this design doc? Unit test is quite important to make sure config.bcm is consistent after this feature.

• could you please consider .j2 format for common config.bcm? Support to add the logic for some specific HwSku or other scenarios?

[geans-pin]

Fix review comments :

1. Add #section to control property level overwrite in common config
2. ADD mode UT cases

[gord1306]

One question is whether the common config can be supported for migration during image installation?

[geans-pin]

One question is whether the common config can be supported for migration during image installation?

No, the common config merged is happened in the runtime syncd/sai initialize.

Geans

[adyeung]

@ZhaohuiS @venkatmahalingam @gord1306 HLD has been reviewed at the SONiC community review meeting on 11/5/24, if you don't have any further comments, pls help sign off and approve. This feature is targeted for 202411.

[gord1306]

One question is whether the common config can be supported for migration during image installation?

No, the common config merged is happened in the runtime syncd/sai initialize.

Geans

@geans-pin What I mean is not the merge operation. I'm just wondering if it isn’t copied to the new image's partition during installation, similar to how /etc/sonic/config_db.json is copied during the sonic-installer install process. If not, does that mean the user must adjust it manually after upgrading the image?

[ZhaohuiS]

@ZhaohuiS @venkatmahalingam @gord1306 HLD has been reviewed at the SONiC community review meeting on 11/5/24, if you don't have any further comments, pls help sign off and approve. This feature is targeted for 202411.

@geans-pin Did you verify whether all sonic hwskus work well with enabling the mering functionality with the latest common config.bcm?

Could you please provide the test evidence?

[geans-pin]

@ZhaohuiS @venkatmahalingam @gord1306 HLD has been reviewed at the SONiC community review meeting on 11/5/24, if you don't have any further comments, pls help sign off and approve. This feature is targeted for 202411.

@geans-pin Did you verify whether all sonic hwskus work well with enabling the mering functionality with the latest common config.bcm?

Could you please provide the test evidence?

Yes, it works fine on our on-hand SONIC ODMs platforms. For Arista platforms, which we don't have, please help
to verify if the new changes cover your specific j2 config file.

[geans-pin]

One question is whether the common config can be supported for migration during image installation?

No, the common config merged is happened in the runtime syncd/sai initialize.
Geans

@geans-pin What I mean is not the merge operation. I'm just wondering if it isn’t copied to the new image's partition during installation, similar to how /etc/sonic/config_db.json is copied during the sonic-installer install process. If not, does that mean the user must adjust it manually after upgrading the image?

Unlike the config_db.json, It will not copy to new image partition. The merged happened in the syncd docker SAI initialized syncd_init_common.sh, in the syncd docker the script will copy the device config.bcm to /tmp and running the merged process on the tmp folder. For a new image install, user doesn't need to adjust anything.

Geans

[geans-pin]

@ZhaohuiS @venkatmahalingam @gord1306 HLD has been reviewed at the SONiC community review meeting on 11/5/24, if you don't have any further comments, pls help sign off and approve. This feature is targeted for 202411.

@geans-pin Did you verify whether all sonic hwskus work well with enabling the mering functionality with the latest common config.bcm?

Could you please provide the test evidence?

I uploaded UT to all these related PRs.

[geans-pin]

common config UT.pdf