-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version cache #10613
Open
Kalimuthu-Velappan
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
Kalimuthu-Velappan:VERSION_CACHE
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Version cache #10613
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,21 +172,40 @@ endif | |
endif | ||
|
||
# Generate the version control build info | ||
SONIC_VERSION_CACHE := $(filter-out none,$(SONIC_VERSION_CACHE_METHOD)) | ||
SONIC_OVERRIDE_BUILD_VARS += SONIC_VERSION_CACHE=$(SONIC_VERSION_CACHE) | ||
SONIC_OVERRIDE_BUILD_VARS += SONIC_VERSION_CACHE_SOURCE=$(SONIC_VERSION_CACHE_SOURCE) | ||
export SONIC_VERSION_CACHE SONIC_VERSION_CACHE_SOURCE | ||
$(shell test -d $(SONIC_VERSION_CACHE_SOURCE) || \ | ||
mkdir -p $(SONIC_VERSION_CACHE_SOURCE) && chmod -f 777 $(SONIC_VERSION_CACHE_SOURCE) 2>/dev/null ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I find error log in the PR validation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is a merge issue. Fixed it. |
||
$(shell SONIC_VERSION_CONTROL_COMPONENTS=$(SONIC_VERSION_CONTROL_COMPONENTS) \ | ||
TRUSTED_GPG_URLS=$(TRUSTED_GPG_URLS) PACKAGE_URL_PREFIX=$(PACKAGE_URL_PREFIX) \ | ||
DBGOPT='$(DBGOPT)' \ | ||
DISTRO=$(BLDENV) \ | ||
SONIC_VERSION_CACHE=$(SONIC_VERSION_CACHE) \ | ||
SONIC_VERSION_CACHE_SOURCE=$(SONIC_VERSION_CACHE_SOURCE) \ | ||
scripts/generate_buildinfo_config.sh) | ||
|
||
# Generate the slave Dockerfile, and prepare build info for it | ||
$(shell CONFIGURED_ARCH=$(CONFIGURED_ARCH) MULTIARCH_QEMU_ENVIRON=$(MULTIARCH_QEMU_ENVIRON) CROSS_BUILD_ENVIRON=$(CROSS_BUILD_ENVIRON) ENABLE_FIPS_FEATURE=$(ENABLE_FIPS_FEATURE) DOCKER_EXTRA_OPTS=$(DOCKER_EXTRA_OPTS) DEFAULT_CONTAINER_REGISTRY=$(DEFAULT_CONTAINER_REGISTRY) j2 $(SLAVE_DIR)/Dockerfile.j2 > $(SLAVE_DIR)/Dockerfile) | ||
$(shell CONFIGURED_ARCH=$(CONFIGURED_ARCH) MULTIARCH_QEMU_ENVIRON=$(MULTIARCH_QEMU_ENVIRON) CROSS_BUILD_ENVIRON=$(CROSS_BUILD_ENVIRON) j2 $(SLAVE_DIR)/Dockerfile.user.j2 > $(SLAVE_DIR)/Dockerfile.user) | ||
$(shell BUILD_SLAVE=y DEFAULT_CONTAINER_REGISTRY=$(DEFAULT_CONTAINER_REGISTRY) scripts/prepare_docker_buildinfo.sh $(SLAVE_BASE_IMAGE) $(SLAVE_DIR)/Dockerfile $(CONFIGURED_ARCH) "" $(BLDENV)) | ||
$(shell CONFIGURED_ARCH=$(CONFIGURED_ARCH) MULTIARCH_QEMU_ENVIRON=$(MULTIARCH_QEMU_ENVIRON) \ | ||
CROSS_BUILD_ENVIRON=$(CROSS_BUILD_ENVIRON) ENABLE_FIPS_FEATURE=$(ENABLE_FIPS_FEATURE) DOCKER_EXTRA_OPTS=$(DOCKER_EXTRA_OPTS) \ | ||
DEFAULT_CONTAINER_REGISTRY=$(DEFAULT_CONTAINER_REGISTRY) j2 $(SLAVE_DIR)/Dockerfile.j2 > $(SLAVE_DIR)/Dockerfile) | ||
$(shell CONFIGURED_ARCH=$(CONFIGURED_ARCH) MULTIARCH_QEMU_ENVIRON=$(MULTIARCH_QEMU_ENVIRON) \ | ||
CROSS_BUILD_ENVIRON=$(CROSS_BUILD_ENVIRON) j2 $(SLAVE_DIR)/Dockerfile.user.j2 > $(SLAVE_DIR)/Dockerfile.user) | ||
|
||
PREPARE_DOCKER=DEFAULT_CONTAINER_REGISTRY=$(DEFAULT_CONTAINER_REGISTRY) BUILD_SLAVE=y DBGOPT='$(DBGOPT)' SONIC_VERSION_CACHE=$(SONIC_VERSION_CACHE) \ | ||
scripts/prepare_docker_buildinfo.sh $(SLAVE_BASE_IMAGE) $(SLAVE_DIR)/Dockerfile $(CONFIGURED_ARCH) "" $(BLDENV) | ||
|
||
$(shell $(PREPARE_DOCKER) ) | ||
# Add the versions in the tag, if the version change, need to rebuild the slave | ||
SLAVE_BASE_TAG = $(shell cat $(SLAVE_DIR)/Dockerfile $(SLAVE_DIR)/buildinfo/versions/versions-* src/sonic-build-hooks/hooks/* | sha1sum | awk '{print substr($$1,0,11);}') | ||
SLAVE_BASE_TAG = $(shell cat $(SLAVE_DIR)/Dockerfile $(SLAVE_DIR)/buildinfo/versions/versions-* src/sonic-build-hooks/hooks/* 2>/dev/null | sha1sum | awk '{print substr($$1,0,11);}') | ||
# Calculate the slave TAG based on $(USER)/$(PWD)/$(CONFIGURED_PLATFORM) to get unique SHA ID | ||
SLAVE_TAG = $(shell (cat $(SLAVE_DIR)/Dockerfile.user $(SLAVE_DIR)/Dockerfile $(SLAVE_DIR)/buildinfo/versions/versions-* .git/HEAD && echo $(USER)/$(PWD)/$(CONFIGURED_PLATFORM)) \ | ||
SLAVE_TAG = $(shell (cat $(SLAVE_DIR)/Dockerfile.user $(SLAVE_DIR)/Dockerfile $(SLAVE_DIR)/buildinfo/versions/versions-* .git/HEAD 2>/dev/null && echo $(USER)/$(PWD)/$(CONFIGURED_PLATFORM)) \ | ||
| sha1sum | awk '{print substr($$1,0,11);}') | ||
|
||
COLLECT_DOCKER=DEFAULT_CONTAINER_REGISTRY=$(DEFAULT_CONTAINER_REGISTRY) DBGOPT='$(DBGOPT)' SONIC_VERSION_CACHE=$(SONIC_VERSION_CACHE) \ | ||
scripts/collect_docker_version_files.sh $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) target $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) $(SLAVE_DIR) $(SLAVE_DIR)/Dockerfile | ||
|
||
OVERLAY_MODULE_CHECK := \ | ||
lsmod | grep -q "^overlay " &>/dev/null || \ | ||
zgrep -q 'CONFIG_OVERLAY_FS=y' /proc/config.gz &>/dev/null || \ | ||
|
@@ -240,6 +259,10 @@ ifneq ($(SONIC_DPKG_CACHE_SOURCE),) | |
DOCKER_RUN += -v "$(SONIC_DPKG_CACHE_SOURCE):/dpkg_cache:rw" | ||
endif | ||
|
||
ifneq ($(SONIC_VERSION_CACHE_SOURCE),) | ||
DOCKER_RUN += -v "$(SONIC_VERSION_CACHE_SOURCE):/vcache:rw" | ||
endif | ||
|
||
ifeq ($(SONIC_ENABLE_SECUREBOOT_SIGNATURE), y) | ||
ifneq ($(SIGNING_KEY),) | ||
DOCKER_SIGNING_SOURCE := $(shell dirname $(SIGNING_KEY)) | ||
|
@@ -328,26 +351,65 @@ DOCKER_BASE_LOG = $(SLAVE_DIR)/$(SLAVE_BASE_IMAGE)_$(SLAVE_BASE_TAG).log | |
DOCKER_LOG = $(SLAVE_DIR)/$(SLAVE_IMAGE)_$(SLAVE_TAG).log | ||
|
||
|
||
DOCKER_BASE_BUILD = docker build --no-cache \ | ||
DOCKER_SLAVE_BASE_BUILD = docker build --no-cache \ | ||
-t $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) \ | ||
--build-arg http_proxy=$(http_proxy) \ | ||
--build-arg https_proxy=$(https_proxy) \ | ||
--build-arg no_proxy=$(no_proxy) \ | ||
$(SLAVE_DIR) $(SPLIT_LOG) $(DOCKER_BASE_LOG) | ||
--build-arg SONIC_VERSION_CACHE=$(SONIC_VERSION_CACHE) \ | ||
--build-arg SONIC_VERSION_CONTROL_COMPONENTS=$(SONIC_VERSION_CONTROL_COMPONENTS) \ | ||
$(SLAVE_DIR) \ | ||
| awk '/^_VCSTART_$$/,/^_VCEND_$$/{if($$0 !~ /_VCSTART_|_VCEND_/)print >"$(SLAVE_BASE_IMAGE)/vcache/cache.base64";next}{print }' \ | ||
$(SPLIT_LOG) $(DOCKER_BASE_LOG) | ||
|
||
|
||
DOCKER_BASE_PULL = docker pull \ | ||
$(REGISTRY_SERVER):$(REGISTRY_PORT)/$(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) | ||
|
||
DOCKER_BUILD = docker build --no-cache \ | ||
DOCKER_USER_BUILD = docker build --no-cache \ | ||
--build-arg user=$(USER) \ | ||
--build-arg uid=$(shell id -u) \ | ||
--build-arg guid=$(shell id -g) \ | ||
--build-arg hostname=$(shell echo $$HOSTNAME) \ | ||
--build-arg slave_base_tag_ref=$(SLAVE_BASE_TAG) \ | ||
--build-arg slave_base_tag_ref=$(SLAVE_BASE_TAG) \ | ||
-t $(SLAVE_IMAGE):$(SLAVE_TAG) \ | ||
-f $(SLAVE_DIR)/Dockerfile.user \ | ||
$(SLAVE_DIR) $(SPLIT_LOG) $(DOCKER_LOG) | ||
|
||
|
||
DOCKER_SLAVE_BASE_BUILD_REGISTRY = \ | ||
{ \ | ||
[ $(ENABLE_DOCKER_BASE_PULL) == y ] && { echo Image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) not found. Pulling...; } && \ | ||
$(DOCKER_BASE_PULL) && \ | ||
{ \ | ||
docker tag $(REGISTRY_SERVER):$(REGISTRY_PORT)/$(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) && \ | ||
$(COLLECT_DOCKER) ; \ | ||
} \ | ||
} || \ | ||
{ \ | ||
echo Image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) not found in registry. Building... ; \ | ||
$(PREPARE_DOCKER) ; \ | ||
$(DOCKER_SLAVE_BASE_BUILD) ; \ | ||
$(COLLECT_DOCKER) ; \ | ||
} | ||
|
||
SONIC_SLAVE_BASE_BUILD = \ | ||
echo Checking sonic-slave-base image: $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG); \ | ||
docker inspect --type image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) &> /dev/null || \ | ||
{ \ | ||
echo Image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) not found. Building... ; \ | ||
$(DOCKER_SLAVE_BASE_BUILD_REGISTRY) ; \ | ||
} | ||
|
||
SONIC_SLAVE_USER_BUILD = \ | ||
echo Checking sonic-slave image: $(SLAVE_IMAGE):$(SLAVE_TAG); \ | ||
docker inspect --type image $(SLAVE_IMAGE):$(SLAVE_TAG) &> /dev/null || \ | ||
{ \ | ||
echo Image $(SLAVE_IMAGE):$(SLAVE_TAG) not found. Building... ; \ | ||
$(DOCKER_USER_BUILD) ; \ | ||
} | ||
|
||
|
||
SONIC_BUILD_INSTRUCTION := make \ | ||
-f slave.mk \ | ||
PLATFORM=$(PLATFORM) \ | ||
|
@@ -412,9 +474,16 @@ SONIC_BUILD_INSTRUCTION := make \ | |
|
||
.PHONY: sonic-slave-build sonic-slave-bash init reset | ||
|
||
|
||
COLLECT_BUILD_VERSION = DBGOPT='$(DBGOPT)' scripts/collect_build_version_files.sh $$? | ||
ifneq ($(filter clean,$(MAKECMDGOALS)),) | ||
COLLECT_BUILD_VERSION="echo " | ||
endif | ||
|
||
|
||
.DEFAULT_GOAL := all | ||
|
||
%:: | ||
%::|sonic-build-hooks | ||
ifneq ($(filter y, $(MULTIARCH_QEMU_ENVIRON) $(CROSS_BUILD_ENVIRON)),) | ||
@$(DOCKER_MULTIARCH_CHECK) | ||
ifneq ($(BLDENV), ) | ||
|
@@ -423,57 +492,38 @@ ifneq ($(BLDENV), ) | |
endif | ||
endif | ||
@$(OVERLAY_MODULE_CHECK) | ||
@$(SONIC_SLAVE_BASE_BUILD) | ||
@$(SONIC_SLAVE_USER_BUILD) | ||
|
||
@pushd src/sonic-build-hooks; TRUSTED_GPG_URLS=$(TRUSTED_GPG_URLS) make all; popd | ||
@cp src/sonic-build-hooks/buildinfo/sonic-build-hooks* $(SLAVE_DIR)/buildinfo | ||
@docker inspect --type image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) &> /dev/null || \ | ||
{ [ $(ENABLE_DOCKER_BASE_PULL) == y ] && { echo Image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) not found. Pulling...; } && \ | ||
$(DOCKER_BASE_PULL) && \ | ||
{ docker tag $(REGISTRY_SERVER):$(REGISTRY_PORT)/$(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) && \ | ||
scripts/collect_docker_version_files.sh $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) target ; } } || \ | ||
{ echo Image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) not found. Building... ; \ | ||
$(DOCKER_BASE_BUILD) ; \ | ||
scripts/collect_docker_version_files.sh $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) target ; } | ||
@docker inspect --type image $(SLAVE_IMAGE):$(SLAVE_TAG) &> /dev/null || \ | ||
{ echo Image $(SLAVE_IMAGE):$(SLAVE_TAG) not found. Building... ; \ | ||
$(DOCKER_BUILD) ; } | ||
ifeq "$(KEEP_SLAVE_ON)" "yes" | ||
ifdef SOURCE_FOLDER | ||
@$(DOCKER_RUN) -v $(SOURCE_FOLDER):/var/$(USER)/src $(SLAVE_IMAGE):$(SLAVE_TAG) bash -c "$(SONIC_BUILD_INSTRUCTION) $@; scripts/collect_build_version_files.sh \$$?; /bin/bash" | ||
@$(DOCKER_RUN) -v $(SOURCE_FOLDER):/var/$(USER)/src $(SLAVE_IMAGE):$(SLAVE_TAG) bash -c "$(SONIC_BUILD_INSTRUCTION) $@; $(COLLECT_BUILD_VERSION); /bin/bash" | ||
else | ||
@$(DOCKER_RUN) $(SLAVE_IMAGE):$(SLAVE_TAG) bash -c "$(SONIC_BUILD_INSTRUCTION) $@; scripts/collect_build_version_files.sh \$$?; /bin/bash" | ||
@$(DOCKER_RUN) $(SLAVE_IMAGE):$(SLAVE_TAG) bash -c "$(SONIC_BUILD_INSTRUCTION) $@; $(COLLECT_BUILD_VERSION); /bin/bash" | ||
endif | ||
else | ||
@$(DOCKER_RUN) $(SLAVE_IMAGE):$(SLAVE_TAG) bash -c "$(SONIC_BUILD_INSTRUCTION) $@; scripts/collect_build_version_files.sh \$$?" | ||
@$(DOCKER_RUN) $(SLAVE_IMAGE):$(SLAVE_TAG) bash -c "$(SONIC_BUILD_INSTRUCTION) $@; $(COLLECT_BUILD_VERSION);" | ||
@$(docker-image-cleanup) | ||
endif | ||
|
||
docker-cleanup: | ||
$(docker-image-cleanup) | ||
@$(docker-image-cleanup) | ||
|
||
.PHONY: sonic-build-hooks | ||
sonic-build-hooks: | ||
@pushd src/sonic-build-hooks; TRUSTED_GPG_URLS=$(TRUSTED_GPG_URLS) make all; popd | ||
@mkdir -p $(SLAVE_DIR)/buildinfo | ||
@cp src/sonic-build-hooks/buildinfo/sonic-build-hooks* $(SLAVE_DIR)/buildinfo | ||
|
||
sonic-slave-base-build : sonic-build-hooks | ||
sonic-slave-base-build : |sonic-build-hooks | ||
ifeq ($(MULTIARCH_QEMU_ENVIRON), y) | ||
@$(DOCKER_MULTIARCH_CHECK) | ||
endif | ||
@$(OVERLAY_MODULE_CHECK) | ||
@echo Checking sonic-slave-base image: $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) | ||
@docker inspect --type image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) &> /dev/null || \ | ||
{ [ $(ENABLE_DOCKER_BASE_PULL) == y ] && { echo Image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) not found. Pulling...; } && \ | ||
$(DOCKER_BASE_PULL) && \ | ||
{ docker tag $(REGISTRY_SERVER):$(REGISTRY_PORT)/$(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) && \ | ||
scripts/collect_docker_version_files.sh $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) target ; } } || \ | ||
{ echo Image $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) not found. Building... ; \ | ||
$(DOCKER_BASE_BUILD) ; \ | ||
scripts/collect_docker_version_files.sh $(SLAVE_BASE_IMAGE):$(SLAVE_BASE_TAG) target ; } | ||
@$(SONIC_SLAVE_BASE_BUILD) | ||
|
||
sonic-slave-build : sonic-slave-base-build | ||
@echo Checking sonic-slave image: $(SLAVE_IMAGE):$(SLAVE_TAG) | ||
@docker inspect --type image $(SLAVE_IMAGE):$(SLAVE_TAG) &> /dev/null || \ | ||
{ echo Image $(SLAVE_IMAGE):$(SLAVE_TAG) not found. Building... ; \ | ||
$(DOCKER_BUILD) ; } | ||
@$(SONIC_SLAVE_USER_BUILD) | ||
|
||
sonic-slave-bash : sonic-slave-build | ||
@$(DOCKER_RUN) -t $(SLAVE_IMAGE):$(SLAVE_TAG) bash | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,7 @@ log_green = echo -e "$(GREEN)$(1)$(GRAY)" | |
FLUSH_LOG = rm -f [email protected] | ||
|
||
LOG_SIMPLE = &>> $(PROJECT_ROOT)/[email protected] || { [ $$? -eq 0 ] || pushd $(PROJECT_ROOT) > /dev/null ; ./update_screen.sh -e $@ ; popd > /dev/null ; false ; } | ||
LOG_SAVE = |& $(PROJECT_ROOT)/scripts/process_log.sh $(PROCESS_LOG_OPTION) &>> $(PROJECT_ROOT)/[email protected] ; test $${PIPESTATUS[-2]} -eq 0 || { [ $$? -eq 0 ] || pushd $(PROJECT_ROOT) > /dev/null ; ./update_screen.sh -e $@ ; popd > /dev/null ; false ; } | ||
LOG = < /dev/null |& $(PROJECT_ROOT)/scripts/process_log.sh $(PROCESS_LOG_OPTION) &>> $(PROJECT_ROOT)/[email protected] ; test $${PIPESTATUS[-2]} -eq 0 || { [ $$? -eq 0 ] || pushd $(PROJECT_ROOT) > /dev/null ; ./update_screen.sh -e $@ ; popd > /dev/null ; false ; } | ||
|
||
############################################################################### | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part has been merged into master branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is added as a default rule in the Makefile.work for each distro build(stretch, buster and bullseye)