-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Arista] Fix content of platform.json for DCS-7050CX3-32S #12082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prgeor
approved these changes
Sep 21, 2022
@andywongarista could you rebase with master once? |
1 similar comment
@andywongarista could you rebase with master once? |
601fffe
to
d359448
Compare
prgeor
approved these changes
Oct 19, 2022
7 tasks
@yxieca not sure if this is already cherry-picked into 202205 as commented by @andywongarista above |
@andywongarista PR conflicts with 202205 branch |
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
8 tasks
Cherry pick PR merged: #13659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Some tests under
platform_tests/api
were failing on the 7050CX3 due to outdated facts in platform.jsonHow I did it
Updated platform.json facts with appropriate values
How to verify it
Run tests under
platform_tests/api
to verify no failuresWhich release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)